Found a bad translation

• • Reply

  13 years ago

  by NeoVerigo

  JJ Bussert

  , United States

  Joined 13 years ago

  Great Tool, I wub U

  Found An incorrect translation.

  C#

      public class PropertyOrderPair : IComparable
      {
          private int _order;
          private string _name;
          public string Name
          {
              get
              {
                  return _name;
              }
          }

          public PropertyOrderPair(string name, int order)
          {
              _order = order;
              _name = name;
          }

          public int CompareTo(object obj)
          {
              //
              // Sort the pair objects by ordering by order value
              // Equal values get the same rank
              //
              int otherOrder = ((PropertyOrderPair)obj)._order;
              if (otherOrder == _order)
              {
                  //
                  // If order not specified, sort by name
                  //
                  string otherName = ((PropertyOrderPair)obj)._name;
                  return string.Compare(_name,otherName);
              }
              else if (otherOrder > _order)
              {
                  return -1;
              }
              return 1;
          }
      }

   VB translation:

  3.     Public Class PropertyOrderPair
  5.         Implements IComparable
  6.         Private _order As Integer
  7.         Private _name As String
  8.         Public ReadOnly Property Name() As String
  9.             Get
  10.                 Return _name
  11.             End Get
  12.         End Property
  13.        
  14.         Public Sub New(ByVal name As String, ByVal order As Integer)
  15.             _order = order
  16.             _name = name
  17.         End Sub
  18.        
  19.         Public Function CompareTo(ByVal obj As Object) As Integer
  20.             '
  21.             ' Sort the pair objects by ordering by order value
  22.             ' Equal values get the same rank
  23.             '
  24.             Dim otherOrder As Integer = DirectCast(obj, PropertyOrderPair)._order
  25.             If otherOrder = _order Then
  26.                 '
  27.                 ' If order not specified, sort by name
  28.                 '
  29.                 Dim otherName As String = DirectCast(obj, PropertyOrderPair)._name
  30.                 Return String.Compare(_name, otherName)
  31. ElseIf otherOrder > _order Then
  32.                 Return -1
  33.             End If
  34.             Return 1
  35.         End Function
  36.     End Class

  What it should be:

  Line 19 should be:

  Public Overloads Function CompareTo(ByVal obj As Object) As Integer Implements IComparable.CompareTo

   

  Report abuse
• • Reply

  13 years ago

  by James Crowley

  James Crowley

  London, United Kingdom

  Joined 20 years ago

  Hi! Thanks for the bug report. Unfortunately there's no way the code converter is ever going to be able to support that in general. At the moment it statically analyses the code by turning it into what is known as an abstract syntax tree... and it has no way of knowing from the C# code which methods are in fact implementations of that interface and whcih are not (as it has no definition of that interface...). That said, even if you gave it the definition of the interface, it's not smart enough to work that out yet!

  Ah well... 

  Report abuse